Rust: fix workspace member aggregation when absolute path is a glob pattern #19293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attern We were interpreting the absolute path of a workspace as a glob pattern, which doesn't work if the path has some special characters (e.g. `[` or `]`).
There was a problem hiding this comment.
Pull Request Overview
This PR fixes workspace member aggregation by resolving an issue where workspace absolute paths containing special characters were misinterpreted as glob patterns.
- Change the matching behavior by stripping the workspace_dir from the target path.
- Compare the resulting relative path against each member glob pattern from the workspace configuration.
Comments suppressed due to low confidence (1)
rust/extractor/src/rust_analyzer.rs:179
- [nitpick] The closure parameter 'p' is used for both the member string and the generated glob::Pattern. Consider renaming the inner parameter (or both) to more descriptive names (e.g., 'pattern_str' and 'pattern') to improve clarity.
.any(|p| glob::Pattern::new(p).is_ok_and(|p| p.matches(rel_path.as_str())))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were interpreting the absolute path of a workspace as a glob pattern, which doesn't work if the path has some special characters (e.g.
[or]).